0xMiden / 0xMiden/protocol

Optimize note script encoding

未關閉
#576 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
Rust
星號
132
分支
167
平均合併
1 天 23 小時
30 天內合併 PR
110

描述

### What should be done?

The note script is encoded to/from Felts to push to/from the VM. The current encoding uses `u32`, since a Felt doesn't support the full range of `u64`. But this can be improved by just not having the high bit set, which means one can use 7 bytes out of the 8 bytes in a `u64` to encode the script, and almost double the space efficiency

### How should it be done?

Change the `NoteScript` conversions to/from Felt to use `u64`

### When is this task done?

When the code above is merged and tested

### Additional context

https://github.com/0xPolygonMiden/miden-base/pull/572#discussion_r1555578703

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。