0xMiden / 0xMiden/protocol

Optimize note script encoding

Ouverte
#576 2 commentaires 0 réactions 0 personnes assignées Voir sur GitHub
Langage dominant
Rust
Étoiles
132
Forks
167
Merge moyen
1 j 23 h
PR mergées (30 j)
110

Description

### What should be done?

The note script is encoded to/from Felts to push to/from the VM. The current encoding uses `u32`, since a Felt doesn't support the full range of `u64`. But this can be improved by just not having the high bit set, which means one can use 7 bytes out of the 8 bytes in a `u64` to encode the script, and almost double the space efficiency

### How should it be done?

Change the `NoteScript` conversions to/from Felt to use `u64`

### When is this task done?

When the code above is merged and tested

### Additional context

https://github.com/0xPolygonMiden/miden-base/pull/572#discussion_r1555578703

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.