0xMiden / 0xMiden/protocol

Move `ConversionRate` out of `account::oracle` into a shared module

Abierto
#3,841 0 comentarios 1 reacción 0 asignados Ver en GitHub
standards
Lenguaje dominante
Rust
Estrellas
132
Forks
167
Merge medio
1 d 23 h
PR fusionados (30 d)
110

Descripción

As discussed in this comment: https://github.com/0xMiden/protocol/pull/3561#discussion_r3834672363

`ConversionRate` is in `crates/miden-standards/src/account/oracle/types.rs`, inside the price oracle component's module. However, it is not oracle-specific, a rate is a general-purpose value type, and the fee standard already applies the same concept through `fee::convert_amount`.

So, we should Move `ConversionRate` out of `account::oracle` into a module that both the "oracle" and the "fee standard" can depend on.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.