0xMiden / 0xMiden/protocol

Refactor ad-hoc `miden::standards::note` module into final structure

Abierto
#3,603 0 comentarios 1 reacción 0 asignados Ver en GitHub
standards
Lenguaje dominante
Rust
Estrellas
132
Forks
167
Merge medio
1 d 23 h
PR fusionados (30 d)
110

Descripción

We should remove the temporarily introduced `crates/miden-standards/asm/standards/note/mod.masm` module and move these procedures to more appropriate locations:

- `input_note_get_storage` -> `miden::protocol::input_note::get_storage`
- As part of this, it would be good to move `active_note::write_storage_to_memory` to `miden::protocol::note` as it now applies to both input and active notes.
- `get_recipient_preimage` -> `miden::protocol::note::get_recipient_preimage`. It is a generic note procedure so it lands in `note`.
- Currently the procedure returns just script root and storage commitment, but we may want to make this procedure more complete and also return the serial number, so it is the full preimage.
- Alternatively, we call this something like `get_partial_recipient_preimage` to indicate it returns only part of the preimage. Most callers probably don't need the serial, so this may be preferable and leaves `get_recipient_preimage` for a future full-preimage implementation.
- `output_note_get_recipient_preimage` -> `miden::protocol::output_note::get_recipient_preimage`, which internally uses `note::get_recipient_preimage`.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.