0xMiden / 0xMiden/protocol

Increase length of the RBAC role names

未關閉
#3,287 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
standards
主要語言
Rust
星號
132
分支
167
平均合併
1 天 23 小時
30 天內合併 PR
110

描述

Currently we create our role names internally using `ShortCapitalString` which allows us to have at most 12 chars in the name. The problem is that any attempt to create an admin role for any of our roles (for example, create the `GER_INJECTOR_ADMIN`) will result in an error: name will be too long. So we should either change the way we construct the role name, or somehow update the `ShortCapitalString`, for example, making its `MAX_LENGTH` a constant parameter:
```rust
pub(crate) struct ShortCapitalString(String);
```

_Originally posted by @Fumuran in https://github.com/0xMiden/protocol/issues/3130#issuecomment-4925789869_

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。