0xMiden / 0xMiden/protocol

Batch kernel: apply the 1024 note limit to post-erasure counts

Abierto
#3,184 0 comentarios 0 reacciones 0 asignados Ver en GitHub
kernels
Lenguaje dominante
Rust
Estrellas
132
Forks
167
Merge medio
1 d 23 h
PR fusionados (30 d)
110

Descripción

Follow-up from the PR #2905 review (thread on `asm/kernels/batch/lib/prologue.masm`).

## Problem

`ProposedBatch` enforces `MAX_INPUT_NOTES_PER_BATCH` / `MAX_OUTPUT_NOTES_PER_BATCH` (= 1024) on the **post-erasure** note sets. The batch kernel instead stores the **pre-erasure** union of every transaction's notes in fixed 1024-entry regions, and asserts the pre-erasure length ≤ 1024 before writing.

So a batch with >1024 pre-erasure notes that erases down to ≤ 1024 passes `ProposedBatch` but is rejected by the kernel. It is memory-safe, but some valid batches cannot be proven.

## Temporary mitigation (landed in #2905)

`BatchExecutor::execute` rejects a batch whose pre-erasure input/output union exceeds `MAX_*_NOTES_PER_BATCH`.

## Proper fix

The 1024 limit should stay a **post-erasure** limit

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.