0xMiden / 0xMiden/protocol

Refactor(testing): extract shared multisig auth test setup helper

Aberta
#2,869 1 comentário 1 reação 0 responsáveis Ver no GitHub
Linguagem predominante
Rust
Estrelas
132
Forks
167
Merge médio
1d 23h
PRs com merge (30d)
110

Descrição

> [crates/miden-testing/tests/auth/multisig_smart.rs]
> ```
> (Vec, Vec, Vec, Vec);
>
> /// Sets up secret keys, auth schemes, public keys, and authenticators for a specific scheme.
> fn setup_keys_and_authenticators_with_scheme(
> ```
> Is it not possible to reuse the existing setup_keys_and_authenticators_with_scheme function which we use in the existing mutlisig?

Originally by: @partylikeits1983 in https://github.com/0xMiden/protocol/pull/2806

Extract the helper into a shared module reachable from every auth test:

```
crates/miden-testing/tests/auth/
mod.rs
common.rs # new — pub fn setup_keys_and_authenticators_with_scheme + MultisigTestSetup
multisig.rs
multisig_smart.rs
guarded_multisig.rs
hybrid_multisig.rs
```

Each test file then replaces its local copy with:

`use crate::auth::common::{MultisigTestSetup, setup_keys_and_authenticators_with_scheme};`

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.