0xMiden / 0xMiden/protocol

AggLayer: Track GER insertion hash chain

Aperta
#2,707 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
agglayer
Lingua principale
Rust
Stelle
132
Fork
167
Merge medio
1g 23h
PR unite (30g)
110

Descrizione

## Description

The Solidity sovereign chain GER manager ([`GlobalExitRootManagerL2SovereignChain.sol`](https://github.com/agglayer/agglayer-contracts/blob/main/contracts/v2/sovereignChains/GlobalExitRootManagerL2SovereignChain.sol)) maintains a running hash chain of all inserted GERs via `insertedGERHashChain`. Each call to `insertGlobalExitRoot()` updates this chain: `insertedGERHashChain = efficientKeccak256(insertedGERHashChain, _newRoot)`. This enables compact proofs of the complete GER insertion sequence. The GER insertion hash chain is something sovereign chains can opt into, not a hard requirement from the base bridge protocol.

The Miden bridge's [`update_ger`](https://github.com/0xMiden/miden-base/blob/next/crates/miden-agglayer/asm/agglayer/bridge/bridge_config.masm) procedure stores the GER in the `ger_map` but does not update any chain hash. The bridge does maintain a Claimed Global Index (CGI) chain hash via the `cgi_chain_hash_lo/hi` slots (updated in [`bridge_in::claim`](https://github.com/0xMiden/miden-base/blob/next/crates/miden-agglayer/asm/agglayer/bridge/bridge_in.masm)), but there is no analogous tracking for GER insertions.

## Impact

The bridge cannot generate compact proofs of which GERs have been inserted and in what order. This may affect the ability of the prover to construct validity proofs that include GER state transitions, and makes auditing the GER insertion history more difficult.

## Recommended Action

Maintain a running Keccak-256 hash chain of all inserted GERs, following the same pattern as the existing CGI chain hash (`cgi_chain_hash_lo/hi` slots). Modify `update_ger` to compute `Keccak256(old_chain || GER)` after each insertion and store the result. The procedure will need to be restructured to preserve the original GER values before the Poseidon hash, since the chain hash requires the raw GER.

## References

- [`bridge_config.masm`](https://github.com/0xMiden/miden-base/blob/next/crates/miden-agglayer/asm/agglayer/bridge/bridge_config.masm) (`update_ger`)
- [`bridge.rs`](https://github.com/0xMiden/miden-base/blob/next/crates/miden-agglayer/src/bridge.rs)
- [`GlobalExitRootManagerL2SovereignChain.sol`](https://github.com/agglayer/agglayer-contracts/blob/main/contracts/v2/sovereignChains/GlobalExitRootManagerL2SovereignChain.sol)

## Classification

This feature is part of the sovereign chain extension (`GlobalExitRootManagerL2SovereignChain`), not the base bridge contract. The GER insertion hash chain is something sovereign chains can opt into, not a hard requirement from the base bridge protocol.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.