0xMiden / 0xMiden/protocol

Fix note checker

Aperta
#2,457 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
standards
Lingua principale
Rust
Stelle
132
Fork
167
Merge medio
1g 23h
PR unite (30g)
110

Descrizione

Our current [note checker](https://github.com/0xMiden/miden-base/blob/753fb1c9a24bad4dc891bc784a635ba5089c2c99/crates/miden-standards/src/note/mod.rs#L202) has a bug: `reclaim_height == 0` is considered as if the note could be always reclaimed, while in fact that means that the reclaim is disabled, so the note could never be reclaimed.

We should fix this bug and update our tests to check this scenario.

For more detailed explanation see [this discussion](https://github.com/0xMiden/miden-base/pull/2389#discussion_r2794376630).

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.