Fix note checker
Open
standards
- Dominant language
- Rust
- Stars
- 132
- Forks
- 167
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 110
Description
Our current [note checker](https://github.com/0xMiden/miden-base/blob/753fb1c9a24bad4dc891bc784a635ba5089c2c99/crates/miden-standards/src/note/mod.rs#L202) has a bug: `reclaim_height == 0` is considered as if the note could be always reclaimed, while in fact that means that the reclaim is disabled, so the note could never be reclaimed.
We should fix this bug and update our tests to check this scenario.
For more detailed explanation see [this discussion](https://github.com/0xMiden/miden-base/pull/2389#discussion_r2794376630).
Contributor guide
Assessment
This issue has not been assessed yet.