0xMiden / 0xMiden/protocol

Optimize AccountCode equality comparison performance

Aperta
#2,429 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
132
Fork
167
Merge medio
1g 23h
PR unite (30g)
110

Descrizione

The PartialEq implementation for AccountCode compares the entire MastForest, which is slow for large code structures.

Since commitment uniquely identifies the account code (and is already used for Ord), we should use it for equality checks instead of comparing the full MastForest.

Current code:

`self.mast == other.mast && self.procedures == other.procedures`

Expected change:

Compare by commitment and procedures instead of mast and procedures.

There's already a TODO comment in the code suggesting this optimization (line 234). This should improve performance without changing correctness, since commitment is deterministic and uniquely identifies the code interface.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.