Optimize AccountCode equality comparison performance
- Ngôn ngữ chính
- Rust
- Star
- 132
- Fork
- 167
- Merge trung bình
- 1 ngày 23 giờ
- Pull request đã merge (30 ngày)
- 110
Mô tả
The PartialEq implementation for AccountCode compares the entire MastForest, which is slow for large code structures.
Since commitment uniquely identifies the account code (and is already used for Ord), we should use it for equality checks instead of comparing the full MastForest.
Current code:
`self.mast == other.mast && self.procedures == other.procedures`
Expected change:
Compare by commitment and procedures instead of mast and procedures.
There's already a TODO comment in the code suggesting this optimization (line 234). This should improve performance without changing correctness, since commitment is deterministic and uniquely identifies the code interface.
Hướng dẫn đóng góp
Đánh giá
Issue này chưa được đánh giá.