0xMiden / 0xMiden/protocol

Test partial storage map from foreign account can be accessed

Đang mở
#1,136 2 bình luận 0 reaction 0 người được giao Xem trên GitHub
tests
Ngôn ngữ chính
Rust
Star
132
Fork
167
Merge trung bình
1 ngày 23 giờ
Pull request đã merge (30 ngày)
110

Mô tả

### What should be done?

With foreign procedure invocation it's possible to read data from a foreign account, for example from a storage map. Such storage maps could get very large in practice, but since they are a sparse merkle tree, only the key-value pair that needs to be accessed (and its merkle path) must be present in the transaction where it is read.

### How should it be done?

There are two options I think:
1. We could consider adding a test to make sure we can do this, which also serves as an example of how this can be done.
2. We can change `get_mock_fpi_adv_inputs` to take as an input the key-value pairs that should be added to the advice input's merkle store, so that instead of adding all storage maps to the merkle store, we only selectively add the provided key-value pairs. In that case we don't need a new test, but the existing `test_fpi_memory` would serve as the example because a part of this test already uses `get_map_item`.

I would suggest going with option 2 if there aren't unforeseen complications, and option 1 otherwise.

### When is this task done?

When we can successfully execute a test where not the entire storage map was added to the advice input's merkle store.

### Additional context

Follow-up from #918.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.