0xMiden / 0xMiden/note-transport-service

Health service reports SERVING unconditionally regardless of DB state

Abierto
#127 1 comentario 0 reacciones 0 asignados Ver en GitHub
bug production-readiness
Lenguaje dominante
Rust
Estrellas
3
Forks
10
Merge medio
2 h 23 min
PR fusionados (30 d)
4

Descripción

Severity: high.

### Summary

`health_reporter.set_serving::<…>()` is called once at startup (`crates/node/src/node/grpc/mod.rs:100-101`) and the reporter is then dropped and never consulted again. There is no readiness probe and no NOT_SERVING transition.

### Impact

A wedged/corrupt DB, a full disk, or an exhausted connection pool leaves the pod reporting healthy; load balancers keep routing traffic into a black hole. (The health service existing at all is good — this is about keeping it truthful.)

### Recommendation

Keep the reporter, run a periodic readiness probe (`SELECT 1` via the pool) that toggles serving status, and set NOT_SERVING during shutdown (ties into the graceful-shutdown issue).

---
Part of #114.

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.