0xMiden / 0xMiden/note-transport-service
Server errors exit with code 0 — restart-on-failure never triggers
- Lingua principale
- Rust
- Stelle
- 3
- Fork
- 10
- Merge medio
- 2h 23m
- PR unite (30g)
- 4
Descrizione
Severity: high (bug).
### Summary
`entrypoint()` swallows the server error: `if let Err(e) = self.grpc.serve().await { error!("Server error: {e}"); }` (`crates/node/src/node/mod.rs:59-61`), and `main` then returns `Ok(())` (`bin/node/src/main.rs:83`).
### Impact
A bind failure, transport error, or any fatal server error produces a clean `exit(0)`. Docker `restart: on-failure` and systemd `Restart=on-failure` treat this as success and leave the service down.
### Recommendation
Propagate the error from `entrypoint()` to `main` so the process exits non-zero on fatal error.
---
Part of #114.
Guida per i contributori
Apri la guida per i contributori
Valutazione
Questa issue non è ancora stata valutata.