0xMiden / 0xMiden/note-transport-service

No backup/restore story for the note database

Đang mở
#125 0 bình luận 0 reaction 0 người được giao Xem trên GitHub
enhancement production-readiness
Ngôn ngữ chính
Rust
Star
3
Fork
10
Merge trung bình
2 giờ 23 phút
Pull request đã merge (30 ngày)
4

Mô tả

Severity: high (for the stated production goal).

### Summary

There is no backup mechanism anywhere: no `VACUUM INTO`/`.backup`, no litestream/WAL-shipping sidecar in `bin/node/docker/docker-compose.yml` (only telemetry services), nothing in the `Makefile` (only `docker volume create node-db`), nothing in the docs.

### Impact

For private notes, this DB is the only copy of `NoteDetails` before consumption (per #101's own framing). A lost volume is unrecoverable, fund-relevant data loss — and per the fail-open issue (#124) the service silently restarts empty rather than failing.

### Recommendation

- Minimum viable: periodic `VACUUM INTO '/backup/…'` (safe online under WAL) from the maintenance loop or a cron sidecar, plus documented restore steps.
- Better: litestream or WAL-shipping.
- Note the overlap with #111 — a Postgres backend inherits a mature backup ecosystem.

Related: #111, #112.

---
Part of #114.

Hướng dẫn đóng góp

Mở hướng dẫn đóng góp

Đánh giá

Issue này chưa được đánh giá.

Nhận issue mới trong hộp thư của bạn

Bản tóm tắt ngắn những issue GitHub phù hợp với người mới.