0xMiden / 0xMiden/node

[CI] Add client integration test as an optional PR job

オープン
#597 コメント 0 件 リアクション 1 件 担当者 0 名 GitHub で見る
主要言語
Rust
スター
104
フォーク
138
平均マージ
1日 13時間
マージ済み PR(30日)
56

説明

We sometimes want to verify that the `miden-client`'s integration tests still pass against a PR.

This job should be opt-in only because

1. it's expensive to build and run both the node and integration tests, and
2. the client and node are not developed in lock-step so the tests aren't always conclusive evidence of bad node code

(1) is somewhat solvable using caching, but (2) not so much.

I propose enabling the job using a label, similar to how the changelog check operates (but in reverse). So adding the `client test` label to a PR would trigger and enable the integration test job.

The job would need to

- run the node locally,
- clone `miden-client` and `make integrate-test`

It possible that this is too much work for a generic github worker; we'll have to see how badly this runs.

コントリビューションガイド

コントリビューションガイドを開く

評価

この issue はまだ評価されていません。

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。