0xMiden / 0xMiden/node

Reject transactions that consume fee notes

Open
#2,558 0 comments 1 reaction 1 assignee Claimed by @Mirko-von-Leipzig View on GitHub
block-producer mempool rpc
Dominant language
Rust
Stars
104
Forks
138
Avg merge
1d 13h
Merged PRs (30d)
56

Description

Only the batch builder is allowed to consume these.

Otherwise we would allow:

1. tx a emits fee note a'.
2. tx b emits fee note b' but also consumes (aka steals) a'. This is possible because fee notes are floating.

This would lead to confusing situations in the mempool where a fee note would be attempted to consume multiple times; or in the case where both a & b land in the same batch, that the batch builder doesn't even see a'.

The simplest short term patch is to simply disallow such transactions.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.