Remove or fix `query_plan` module
- 主要語言
- Rust
- 星號
- 104
- 分支
- 138
- 平均合併
- 1 天 13 小時
- 30 天內合併 PR
- 56
描述
The query-plan check was meant to be a test-time guard against accidental full table scans.
Originally the flow was roughly:
- Store queries used the repo’s custom `Transaction` wrapper around `rusqlite::Transaction`.
- Queries prepared SQL through `Transaction::prepare_cached(sql)`.
- In `#[cfg(test)]`, `prepare_cached` called `self.check_query_plan(sql)`.
- check_query_plan ran: `EXPLAIN QUERY PLAN `. It rendered SQLite’s plan and failed the test if it found an unnecessary `SCAN`, while allowing indexed scans like `SCAN ... USING INDEX`.
After the migration to Diesel this is effectively orphaned. We should either find a way to perform the same checks with Diesel or remove this orphaned module entirely.
貢獻指南
評估
這個 Issue 還沒有評估資料。