0xMiden / 0xMiden/node

Execution and signing is blocking in an async runtime

Aperta
#1,976 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
104
Fork
138
Merge medio
1g 13h
PR unite (30g)
56

Descrizione

Some of our program execution occurs within an async context, despite being potentially blocking. This is because the VM exposes an async API, however this only works if the program being executed constantly requires external inputs (which cause it to yield execution).

The same is true for our remote and local proving, and potentially in signing or verification of signatures, or even commitment calculations are causes for concern if not done in a blocking task.

We should find such instances and move them to blocking tasks, or in cases where the API is async, create a dedicated runtime which can isolate the problem.

Known problem areas:

- validator re-executes transactions with provided inputs
- validator signs and hashes
- prover also re-executes, and proves
- network transaction builder executes, and
- also proves if configured for local proving
- store calculates commitments and hashes
- store does verification
- block producer can do local proving

Relates to #1969.

Ideally we would have all blocking tasks isolated, where blocking is defined as `< 100us` between await points.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.