0xMiden / 0xMiden/miden-vm

Consider including `pipe_elements_preimage_to_memory` in `miden::core::mem`

未关闭
#3,362 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
core corelib
主要语言
Rust
星标
772
派生
352
平均合并
1 天 7 小时
30 天内合并 PR
84

描述

Consider including [`pipe_elements_preimage_to_memory`](https://github.com/0xMiden/protocol/blob/d00c73562d13a9dce02c44698d7357e05d770a1d/crates/miden-protocol/asm/protocol_utils/src/mem.masm ) into `miden::core::mem`.

Its behavior falls a bit in between the existing "pipe preimage" and "pipe" procedures. I.e. it constructs a hasher state internally and does not check that the commitment matches (so that callers can do this with their own error message).

The hasher state construction is most of what makes this procedure useful, so the two open questions are:
- should it assert the commitment matches?
- is this generally useful enough to justify moving to `miden::core`?

贡献指南

打开贡献指南

调研方向

Examine the existing pipe preimage and pipe procedures in miden::core::mem to understand the pattern. Review the linked procedure in the protocol repository to see its hasher state construction. Determine if the commitment assertion should be added and if the procedure is general enough for core. Testing involves verifying the procedure works correctly in the VM context.

由索引模型根据 Issue 内容生成。

评估

技术栈
rust
领域
backend
Issue 类型
功能
难度
3/5
预计耗时
1-2 天
活跃度
冷清
描述清晰度
基本清楚
新手友好度
45/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。