0xMiden / 0xMiden/miden-vm

Consider including `pipe_elements_preimage_to_memory` in `miden::core::mem`

Ouverte
#3,362 1 commentaire 0 réactions 0 personnes assignées Voir sur GitHub
core corelib
Langage dominant
Rust
Étoiles
772
Forks
352
Merge moyen
1 j 12 h
PR mergées (30 j)
93

Description

Consider including [`pipe_elements_preimage_to_memory`](https://github.com/0xMiden/protocol/blob/d00c73562d13a9dce02c44698d7357e05d770a1d/crates/miden-protocol/asm/protocol_utils/src/mem.masm ) into `miden::core::mem`.

Its behavior falls a bit in between the existing "pipe preimage" and "pipe" procedures. I.e. it constructs a hasher state internally and does not check that the commitment matches (so that callers can do this with their own error message).

The hasher state construction is most of what makes this procedure useful, so the two open questions are:
- should it assert the commitment matches?
- is this generally useful enough to justify moving to `miden::core`?

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.