0xMiden / 0xMiden/miden-vm

Allow constants in `adv_map` definition

未关闭
#2,500 12 条评论 0 个 reaction 已指派 2 人 已被 @mooori 认领 在 GitHub 查看
assembly
主要语言
Rust
星标
772
派生
352
平均合并
1 天 12 小时
30 天内合并 PR
93

描述

### Feature description

Currently the only way to create an advice map from the assembly code is to use the `Felt`s themselves. Here is the code fragment from the `grammar.lalrpop` file:
` "adv_map" <...> "=" "[" > "]" `

It would be very convenient to be able to use the constants in addition to felts, so changing the above code to something like:
` "adv_map" <...> "=" "[" > "]" `

### Why is this feature needed?

This feature will massively simplify the development of the new Agglayer functionality, namely the Keccak-based MMR frontier.

Its main algorithm requires to have a list of canonical zeros in memory, and the most efficient way to load them there is to use the advice map. These canonical zeros are generated as constants in a separate file, so for now they cannot be used as `adv_map` values.

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。