0xMiden / 0xMiden/miden-vm

Events: Consider returning a `EventHandlerRegister` from `StdLibrary::handlers`

Aberta
#2,222 7 comentários 0 reações 1 responsável Reivindicada por @adr1anh Ver no GitHub
processor
Linguagem predominante
Rust
Estrelas
772
Forks
352
Merge médio
1d 12h
PRs com merge (30d)
93

Descrição

With the introduction of new the event handling infrastructure, users of `miden-vm` who implement their own `Host` need to manually handle these events. The straight forward approach is to define an `EventHandlerRegistry` for all library-defined events, which would be invoked as a fall-through if none of the native events match the one on the stack.

To make things easier, we make it a convention that libraries return an `EventHandlerRegister` directly which is easier to embed inside an existing `Host` implementation. The main drawback would be that we would then have multiple successive registries, but would make it simpler to include handlers from multiple registries.

As a bonus feature, we should also implement `EventHandler for EventHandlerRegistry` since a collection of handlers is itself a handler.

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.