0xMiden / 0xMiden/miden-vm

Adopt standard Rust conventions for crate re-exports

Open
#1,930 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
772
Forks
352
Avg merge
1d 12h
Merged PRs (30d)
93

Description

This follows from an internal discussion.

From @bitwalker:

>IMO we should follow the normal Rust conventions for this stuff; you should re-export crates whose types you use in your public APIs, to avoid incompatible type errors downstream, but re-exporting the types themselves is not usually done.
>
>i.e. pub use miden_core; not pub use miden_core::{Felt, ...}

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.