0xMiden / 0xMiden/miden-vm

Detect invalid stack access by child procedure

Aperta
#1,356 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
772
Fork
352
Merge medio
1g 12h
PR unite (30g)
93

Descrizione

Here is an example of a subtle bug:

```
#! Input: [idx]
#! Output: [addr]
proc.compute_address
push.BASE_ADDR movup.2 add
end

#! Input: [idx]
#! Output: []
proc.save_index
dup exec.compute_address memstore
end
```

The issue above is that `movup.2` touches part of the stack it shouldn't, the code works because the expected value happened to be duplicated by the parent, and the final stack state matched the expected state, even though the instruction used was "incorrect". The issue above won't be caught by tests unless `compute_address` is carefully tested.

The example above happened in the kernel:

- [here](https://github.com/0xPolygonMiden/miden-base/blob/6184966b87f26c0a30b79b277e760d291ae6f493/miden-lib/asm/miden/kernels/tx/prologue.masm#L843) the parent procedure duplicates the top of the stack
- [here](https://github.com/0xPolygonMiden/miden-base/blob/6184966b87f26c0a30b79b277e760d291ae6f493/miden-lib/asm/miden/kernels/tx/prologue.masm#L615-L617) the child procedure uses the value saved in the stack as part of the parent state

The tests didn't caught the issue, because `process_input_note` is not tested directly, only via the `prepare_transaction`. The code doesn't contain an error, but it is confusing.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.