0xMiden / 0xMiden/feedback

Refactor Confirmation Page to execute transaction

Open
#55 0 comments 0 reactions 1 assignee Claimed by @evanmarshall View on GitHub
wallet
Dominant language
No language data
Stars
1
Forks
0
PR merge metrics
No merged PRs in 30d

Description

### What should be done?

Currently transactions are done in a generating transaction page inside of the wallet. We should refactor this such that transactions are executed and we can display the transaction summary and request a signature inside of the confirmation page.

### How should it be done?

It should be done by bifurcating the transaction processing flow such that for Dapps, transactions should be executed in one place. If the transaction is locally proven, we still need to have the generating transaction page. The existing transaction flow for transactions generated inside of the wallet through the UI should remain as existing.

### When is this task done?

This task is done when we can display a transaction summary or a transaction result inside of the confirmation page instead of the transaction request. This will give the user more information about what is occurring during a DAP transaction.

### Additional context

This is dependent on: https://github.com/0xMiden/miden-client/pull/1160

Contributor guide

Open the contributing guide

Research direction

The issue references a dependent pull request (#1160) in the miden-client repository. Start by reviewing that PR to understand the transaction processing flow. Look for the confirmation page and transaction generation code in the codebase. The goal is to modify the flow so Dapp transactions are executed and summarized on the confirmation page, while preserving the existing UI-generated transaction flow.

Written by the indexing model from the issue text.

Assessment

Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.