0xMiden / 0xMiden/air-script

Consider adding a fold + reverse operations

Aperta
#481 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
96
Fork
39
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Ideally, we would compute this using a fold or reverse operation here that would be slightly more efficient since we replace the multiplication by an addition
```rust
a_and_b_iter.rev().reduce(|(acc, a_and_b)| acc + acc + a_and_b)
```

More context: limb decompositions can be seen as polynomial evaluation which can be done more efficiently using Horner. We should keep track of the places where we see this pattern and evaluate if it makes sense to add this feature then.
_Originally posted by @adr1anh in https://github.com/0xMiden/air-script/pull/466#discussion_r2382317667_

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Look at the code context from the linked PR #466 discussion to identify the specific location where polynomial evaluation via limb decompositions occurs. Understand the current implementation pattern and how Horner's method could optimize it. The change involves replacing multiplication with addition in a fold or reverse operation, likely in a file handling arithmetic or polynomial computations. Test the refactor by running relevant tests to ensure correctness and performance improvement.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
rust
Ambito
compilers
Tipo di issue
Refactoring
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.