0xMiden / 0xMiden/air-script

Refactor Periodic columns handling in IR and codegen

未關閉
#43 0 則留言 0 個 reaction 已指派 1 人 已被 @jjcnn 認領 在 GitHub 檢視
主要語言
Rust
星號
96
分支
39
PR 合併指標
30 天內沒有已合併 PR

描述

1. Based on @bobbinth's comments on PR #40 [here](https://github.com/0xPolygonMiden/air-dsl/pull/40#discussion_r1007268169), it might be better to change the periodic columns to `Vec>` instead of `Vec>` at IR level as it might be helpful in the future when we may want to evaluate constraints at a random point..

2. Also we could refactor the `to_string()` method for periodic columns proposed by @bobbinth [here](https://github.com/0xPolygonMiden/air-dsl/pull/40#discussion_r1007277015).

> A thought for the future: instead of doing conversions from u64 to Felt here, we could do the following:
> 1. Define static arrays for all periodic columns such that these arrays already contain Felt's.
> 2. Inside get_periodic_column_values() convert these arrays to vectors (which should be just memory copy operations) and return.
> The performance benefit of the above is probably very minor - so, definitely not a high priority item.

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。