0xMiden / 0xMiden/air-script

Change list comprehensions' body from ScalarExpr to Expr

Aperta
#407 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
Rust
Stelle
96
Fork
39
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

The current implementation for nested list-comprehensions only supports creating Vectors of ScalarExpressions, no matter the nesting level

The goal here would be to enable a more general form of nested list comprehensions, akin to a Matrix comprehension.

Based off of this PR:
https://github.com/0xMiden/air-script/pull/400#issue-3065707667

Task list:
- [ ] Replace list comprehension bodies from ScalarExpr to Expr
- [ ] Ensure all dimension transformations fit the new general form, I think there may be a few cases where they are not handled in a compatible way due to design assumptions
- [ ] update de docs

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.