07th-mod / 07th-mod/tsumihoroboshi
Text speed overriden for too long
- Linguagem predominante
- Sem dados de linguagem
- Estrelas
- 15
- Forks
- 10
- Métricas de merge de PRs
- Nenhum PR com merge em 30d
Descrição
We had a report that the text speed was not obeyed. It turned out that we had a `SetSpeedOfMessage( TRUE, 128 );` without a corresponding `SetSpeedOfMessage( FALSE, 0 );`
> Starts on line 436: https://github.com/07th-mod/tsumihoroboshi/blob/32b8274a77b0fa6204c768743fe0e31aad93f4e8/Update/_tsum_012_2.txt#L436
>
> Your screenshot is line 764: https://github.com/07th-mod/tsumihoroboshi/blob/32b8274a77b0fa6204c768743fe0e31aad93f4e8/Update/_tsum_012_2.txt#L764
>
> Finishes on line 1052: https://github.com/07th-mod/tsumihoroboshi/blob/32b8274a77b0fa6204c768743fe0e31aad93f4e8/Update/_tsum_012_2.txt#L1052-L1056
I asked orian and it should be fine to remove it.
----
I decided to scan all our game scripts for similar issues (for cases where at least 500 japanese characters are emitted or end of file was reached):
If it says "at EOF", it means the file was missing a `SetSpeedOfMessage( FALSE, 0 );` before the file ended. I'm not sure if you require this in a script file or it will carry over to the next script file.
The ones marked "DUP" mean that two` SetSpeedOfMessage( True, ...)` were encountered without having a corresponding `SetSpeedOfMessage( FALSE, ...)`
- [x] Text: 786 Forced Lines: 156 in file 5 meakashi\Update\_meak_020.txt at line 5212-5368
- [x] Text: 786 Forced Lines: 156 in file 5 meakashi\Update\_meak_020.txt at line 5212-5368 DUP
- [x] Text: 861 Forced Lines: 194 in file 5 meakashi\Update\_meak_ep_01.txt at line 11-205
- [x] Text: 1366 Forced Lines: 452 in file 5 meakashi\Update\_meak_ep_02.txt at line 186-638 DUP
----
- [x] Text: 390 Forced Lines: 146 in file 6 tsumihoroboshi\Update\_tsum_003_3.txt at line 1738-1884 (at EOF)
- [x] Text: 2017 Forced Lines: 620 in file 6 tsumihoroboshi\Update\_tsum_012_2.txt at line 436-1056 DUP
- [x] Text: 6473 Forced Lines: 1265 in file 6 tsumihoroboshi\Update\_tsum_013.txt at line 1226-2491 (at EOF)
- [x] Text: 534 Forced Lines: 279 in file 6 tsumihoroboshi\Update\_tsum_tips_005.txt at line 15-294
Some of these I fixed by comparing with the unmodded game, but even in the unmodded game there was one place where I'm pretty sure it was missing a text speed reset.
----
- [ ] Text: 4109 Forced Lines: 1111 in file 7 minagoroshi\Update\_mina_002_1.txt at line 4478-5589
- [ ] Text: 3167 Forced Lines: 722 in file 7 minagoroshi\Update\_mina_006.txt at line 1061-1783 DUP
- [ ] Text: 5278 Forced Lines: 1477 in file 7 minagoroshi\Update\_mina_008.txt at line 1098-2575 DUP
- [ ] Text: 1462 Forced Lines: 360 in file 7 minagoroshi\Update\_mina_013.txt at line 704-1064 DUP
- [ ] Text: 2016 Forced Lines: 767 in file 7 minagoroshi\Update\_mina_013.txt at line 3042-3809 DUP
- [ ] Text: 10438 Forced Lines: 2068 in file 7 minagoroshi\Update\_mina_014.txt at line 978-3046 (at EOF) DUP
- [ ] Text: 1750 Forced Lines: 346 in file 7 minagoroshi\Update\_mina_019.txt at line 3264-3610 DUP
- [ ] Text: 2402 Forced Lines: 599 in file 7 minagoroshi\Update\_mina_022.txt at line 1192-1791
- [ ] Text: 2478 Forced Lines: 690 in file 7 minagoroshi\Update\_mina_022.txt at line 1924-2614 DUP
- [ ] Text: 1323 Forced Lines: 355 in file 7 minagoroshi\Update\_mina_028.txt at line 1919-2274 DUP
----
- [ ] Text: 1532 Forced Lines: 336 in file 8 matsuribayashi\Update\_kakera01.txt at line 347-683 DUP
- [ ] Text: 123 Forced Lines: 61 in file 8 matsuribayashi\Update\_kakera03.txt at line 1318-1379 (at EOF)
- [ ] Text: 718 Forced Lines: 188 in file 8 matsuribayashi\Update\_kakera08.txt at line 421-609 DUP
- [ ] Text: 2598 Forced Lines: 511 in file 8 matsuribayashi\Update\_kakera26.txt at line 20-531 DUP
- [ ] Text: 4299 Forced Lines: 872 in file 8 matsuribayashi\Update\_kakera38.txt at line 33-905 (at EOF) DUP
- [ ] Text: 1010 Forced Lines: 195 in file 8 matsuribayashi\Update\_kakera51.txt at line 895-1090 DUP
- [ ] Text: 1627 Forced Lines: 395 in file 8 matsuribayashi\Update\_kakera51.txt at line 1182-1577 DUP
- [ ] Text: 505 Forced Lines: 381 in file 8 matsuribayashi\Update\_mats_009.txt at line 2750-3131
- [ ] Text: 2180 Forced Lines: 522 in file 8 matsuribayashi\Update\_mats_010.txt at line 1130-1652 (at EOF)
- [ ] Text: 7642 Forced Lines: 1708 in file 8 matsuribayashi\Update\_mats_013.txt at line 1401-3109 (at EOF)
- [ ] Text: 1717 Forced Lines: 440 in file 8 matsuribayashi\Update\_mats_019.txt at line 3173-3613 DUP
- [ ] Text: 522 Forced Lines: 176 in file 8 matsuribayashi\Update\_mats_022.txt at line 2849-3025 DUP
- [ ] Text: 5279 Forced Lines: 1226 in file 8 matsuribayashi\Update\_mats_023.txt at line 1237-2463
----
- [ ] Text: 779 Forced Lines: 254 in file 9 higurashi-rei\Update\batsukoishi01.txt at line 3602-3856 DUP
- [ ] Text: 1491 Forced Lines: 376 in file 9 higurashi-rei\Update\hirukowashi02_3.txt at line 929-1305
- [ ] Text: 711 Forced Lines: 242 in file 9 higurashi-rei\Update\hirukowashi02_3.txt at line 1418-1660
- [ ] Text: 684 Forced Lines: 178 in file 9 higurashi-rei\Update\hirukowashi03.txt at line 1673-1851
- [ ] Text: 614 Forced Lines: 148 in file 9 higurashi-rei\Update\saikoroshi03.txt at line 2035-2183
- [ ] Text: 1420 Forced Lines: 417 in file 9 higurashi-rei\Update\staffroom.txt at line 175-592 DUP
Here is the python script I was using to scan:
[scan.zip](https://github.com/07th-mod/tsumihoroboshi/files/10326701/scan.zip)
Guia de contribuição
Nenhum guia de contribuição indexado para este repositório
Direção de pesquisa
A issue trata sobre chamadas ausentes de `SetSpeedOfMessage(FALSE, 0);` em arquivos de script do jogo. O script Python fornecido (scan.zip) pode ser usado para verificar os arquivos listados. Comece examinando o primeiro arquivo não verificado, por exemplo, `7 minagoroshi\Update\_mina_002_1.txt` nas linhas 4478-5589, e adicione a chamada de redefinição ausente. Teste executando o jogo para garantir que a velocidade do texto se comporte corretamente após a correção.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- python
- Domínio
- game-dev
- Tipo de issue
- Bug
- Dificuldade
- 2/5
- Tempo estimado
- 1-3 horas
- Status de atividade
- Estagnada
- Clareza
- Claramente especificada
- Facilidade para iniciantes
- 75/100