07th-mod / 07th-mod/matsuribayashi

Duplicate voice files

Open
#42 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
24
Forks
13
PR merge metrics
No merged PRs in 30d

Description

We were notified that the following voice files are duplicated in the matsuribayashi scripts, which is probably an error.

Note that some duplicates are already fixed (comitted to this repo), but not in the latest release. Those are not included below.

Most likely we just need to delete the second voice line in all these cases, but each should be checked individually.

> I put hacked a couple shell scripts together to search for more dupes in matsuribayashi. Here are the significant ones I found (that we haven't already fixed):

- [ ] issue 1

```
voice: ……………梨花ちゃん、君はどこでそれを…。
ps3/s13/08/ds41090020
_mats_014.txt: ModPlayVoiceLS(4, 8, "ps3/s13/08/ds41090020", 128, TRUE);
_mats_014.txt- OutputLine(NULL, "「……………梨花ちゃん、君はどこでそれを…。」",
--
_mats_014.txt: ModPlayVoiceLS(4, 8, "ps3/s13/08/ds41090020", 128, TRUE);
_mats_014.txt- OutputLine(NULL, "「…………た、",
```

- [ ] issue 2

```
voice: ……ただ、自らの危機を測るのはとても難しいことです。
ps3/s13/13/ds41120298
_mats_015.txt: ModPlayVoiceLS(4, 13, "ps3/s13/13/ds41120298", 128, TRUE);
_mats_015.txt- OutputLine(NULL, "……ただ、自らの危機を測るのはとても難しいことです。",
--
_mats_020.txt: ModPlayVoiceLS(4, 13, "ps3/s13/13/ds41120298", 128, TRUE);
_mats_020.txt- OutputLine(NULL, " 自らの危機を測るのはとても難しいことです。",
```

- [ ] issue 3

```
voice: このようなところへお越しいただけるとは…。
ps3/s13/00/550300139
_mats_007.txt: ModPlayVoiceLS(4, 0, "ps3/s13/00/550300139", 128, TRUE);
_mats_007.txt- OutputLine(NULL, " このようなところへお越しいただけるとは…。」",
--
_mats_007.txt: ModPlayVoiceLS(4, 0, "ps3/s13/00/550300139", 128, TRUE);
_mats_007.txt- OutputLine(NULL, "「はい。",
```

- [ ] issue 4

```
voice: スピーチあと1人で乾杯に入ります。準備できてるねー?!
ps3/s13/00/vt4a_halll1002
_mats_003.txt: ModPlayVoiceLS(4, 0, "ps3/s13/00/vt4a_halll1002", 128, TRUE);
_mats_003.txt- OutputLine(NULL, " スピーチあと1人で乾杯に入ります。",
--
_mats_010.txt: ModPlayVoiceLS(4, 0, "ps3/s13/00/vt4a_halll1002", 128, TRUE);
_mats_010.txt- OutputLine(NULL, " スピーチあと1人で乾杯に入ります。準備できてるねー?!」",
```

- [ ] issue 5

```
voice: (both lines combined) …だから、…そんな僕をオヤシロさまは許さなかったんだ……。
ps3/s20/07/vtk1_satoshi1131
_kakera08.txt: ModPlayVoiceLS(4, 7, "ps3/s20/07/vtk1_satoshi1131", 128, TRUE);
_kakera08.txt- OutputLine(NULL, "…だから、",
--
_kakera08.txt: ModPlayVoiceLS(4, 7, "ps3/s20/07/vtk1_satoshi1131", 128, TRUE);
_kakera08.txt- OutputLine(NULL, "…そんな僕をオヤシロさまは許さなかったんだ……。",
```

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue lists specific duplicated voice file references in script files like _mats_014.txt and _kakera08.txt. Start by locating these files in the repository, likely under a scripts or similar directory. For each listed duplicate, examine the context lines to verify the duplication and decide whether to delete the second voice line. Check if any recent commits have already addressed some of these. Testing involves ensuring the game still runs correctly after edits.

Written by the indexing model from the issue text.

Assessment

Domain
game-dev
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.