07th-mod / 07th-mod/higurashi-patch-compiler
Console (Sui/Switch/PS3) Background Music and Sound Effects (BGM and SE)
- Lenguaje dominante
- PHP
- Estrellas
- 7
- Forks
- 1
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
@DoctorDiablo @drojf @Grelo @idealpersona @InochiPM @irlPM @ItaloKnox @Norgus
(Wow the team has grown a lot. I hope I didn't forget anyone.)
With the LipSync releases mostly done (save for Meakashi which I'll look into next weekend) it's time to discuss the next release.
From what I know you guys are working on porting some interesting features from Sui. Let's discuss what features we should finish for the next patch and how to incorporate them:
1. Sui video openings
2. Sui background music
3. Sui sound effects (?)
Sui video openings
----
So we have a hacked proof-of-concept DLL capable of playing the videos (thanks @drojf) but it needs more work, right? Can you guys share more details about the current status and how difficult it will be to finish it?
1. When implemented in the DLL, how do we use the feature in the scripts?
2. Are there any limitations or known issues?
3. We'll need some article about how to implement the feature in new chapters which will be released later. Which DLL classes and functions are related, how the implementation works and what possible issues we should be aware of.
Sui background music
----
I know this was mostly done even before the lipsync release but we had to make a feature-freeze somewhere. As much as I'm looking forward to this feature I felt it deserved more attention than we could have given it with all the other features we were adding at the time. Mainly we need to discuss how to add it into the patch since there are several possible options which we should consider carefully. For this reason I rejected it. I apologize for making this decision pretty much alone. I do believe Italo would support me on this one though. Please let me know if you think it was a wrong decision or if I was too hasty with the rejection.
Anyway this allows us to make the next release kind of Sui-themed with adding both audio and video from Higurahi Sui. I'm already quite hyped about it.
From the little information I have about the Sui OST patch it's made automatically by a [script](https://github.com/07th-mod/higurashi-sui-merger) written by @drojf.
Are there any known limitations / caveats for the scripts?
Does it work for all chapters out of the box, including future ones (assuming the language in the scripts will be the same)?
Also it needs the Sui XML - where do we have that? I have some testing versions but I don't think I have the latest.
I'm a bit confused about this from the sui merger readme: "Two merged scripts are generated - one which contains ALL instructions associated with each dialog, and one which has only the BGM play/stop inserted, and the old BGM commands removed." - what does "all instructions" mean in this context?
We also need to discuss how to add it to the game. I can think of several options:
1. Have the commands for both original and Sui BGMs in one script using the `GAltBGMflow` P-Chang added for this purpose.
- Pros: This would be the easiest for the users since the OST would be toggleable in the game.
- Cons:
- The script would be slightly more complicated than it is now.
- The patches would be bigger.
2. Make it an optional feature downloaded manually - separatly from the main patch.
- Pros: Scripts and base patches would stay the same.
- Cons:
- We'd have to recomile the Sui variant for every release.
- It would be more difficult for someone with Sui scripts to make pull requests.
- Save files from one variant would be incompatible with the other.
- Player can't easily switch between the OSTs.
3. Previous option + choice in the installer.
- Pros: Same.
- Cons: Same + installation would be more complicated even when using the installer.
The option number 2 is the easiest to make now and suitable for a beta release in my opinion. This way it could even be released at the same time as stable lipsync patches if desired.
However if we want to really make this feature a part of our patches I'm personally more inclined to number 1 than number 3 due to the listed pros and cons. Did I forget any notable facts or other options?
**Can you guys upload a beta patch with the Sui OST to this issue for testing?**
Sui sound effects (?)
----
If we're adding Sui audios and videos it might be a good idea to also add Sui sound effects (the files in SE directory).
Is this a good idea in your opinion? Should we aim for addint these too?
I believe it should be possible to modify the Sui merger to add this as well?
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Línea de trabajo
El issue trata sobre la integración de música de fondo y efectos de sonido de Sui en un compilador de parches. Comience examinando el script de fusión de Sui existente en https://github.com/07th-mod/higurashi-sui-merger para entender cómo se fusionan BGM/SE. Revise la base de código del compilador de parches para ver dónde se manejan la integración de DLL de audio/vídeo y los comandos de script (como GAltBGMflow). Las pruebas implicarían construir un parche con archivos de audio de Sui y verificar la compatibilidad del script entre capítulos.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- php
- Área
- audio-video-rtc, game-dev
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 30/100