zowe / zowe/api-layer

VSAM property of caching-service never read?

Open
#4,312 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug good first issue Priority: Low size/S
Dominant language
Java
Stars
92
Forks
81
Avg merge
1d 9h
Merged PRs (30d)
46

Description

https://github.com/zowe/api-layer/blob/ab7168637b4a2d7b12e6670880e1d90a36e17d37/apiml-package/src/main/resources/bin/start.sh#L221C12-L221C41

This line of code looks like only "components.apiml.storage.vsam.name" is checked.
Within the conditional, then "components.caching-service.storage.vsam.name" is referenced, but the logic seems like it won't get there.

Instead of

if [ -n "${ZWE_configs_storage_vsam_name}" ]; then
    VSAM_FILE_NAME=//\'${ZWE_configs_storage_vsam_name:-${ZWE_components_caching_service_storage_vsam_name}}\'
fi

Perhaps this will work

if [ -n "${ZWE_configs_storage_vsam_name}" ]; then
    VSAM_FILE_NAME=//\'${ZWE_configs_storage_vsam_name}\'
elif [ -n "${ZWE_configs_storage_vsam_name}" ]; then
    VSAM_FILE_NAME=//\'${ZWE_components_caching_service_storage_vsam_name}\'
fi

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect apiml-package/src/main/resources/bin/start.sh around line 221 and trace the two VSAM environment variables used by the conditional. Done means the caching-service VSAM property can reach the intended fallback logic and the variable checks match the documented configuration names.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
devops
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.