zowe / zowe/api-layer

Remove use of reflection to initialize custom Tomcat connector in modulith mode

Open
#4,211 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug V4
Dominant language
Java
Stars
92
Forks
81
Avg merge
1d 9h
Merged PRs (30d)
46

Description

Describe the bug
This way of implementing the initialization of an additional connector is not recommended as it relies on reflection:

https://github.com/zowe/api-layer/blob/91bf6831dd8a99de201b5b9a81a68fc98dc26194/apiml/src/main/java/org/zowe/apiml/ModulithConfig.java#L272

For v4 Zowe release, this can probably be removed as we can probably eliminate the need for an additional connector as a breaking change

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in apiml/src/main/java/org/zowe/apiml/ModulithConfig.java around line 272, where the additional Tomcat connector is initialized through reflection. Review how modulith mode currently uses that connector and the v4 release context. Done means the reflection-based initialization is removed, with the need for an additional connector resolved consistently for the v4 breaking change.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.