zilliztech / zilliztech/VectorDBBench

"--refine-type" and "--refine-k" should be required only when "--refine" is set to True

Open
#633 1 comment 0 reactions 1 assignee View on GitHub

@alwayslove2013 is already working on this.

Since Nov 25, 2025.

Dominant language
Python
Stars
1.2k
Forks
438
Avg merge
1d 4h
Merged PRs (30d)
1

Description

When "--refine" is set to False, user is still required to set the params "--refine-type" and "--refine-k", it's unreasonable.
"--refine-type" and "--refine-k" should be required only when "--refine" is set to True.

[root@host70 caiyd]# vectordbbench milvushnswsq   --uri "http://10.220.56.72:19530"   --case-type Performance1024D10M  --drop-old   --m 16   --ef-construction 256   --ef-search 100 --refine False
Usage: vectordbbench milvushnswsq [OPTIONS]
Try 'vectordbbench milvushnswsq --help' for help.

Error: Missing option '--refine-type'. Choose from:
        sq6,
        sq8,
        bf16,
        fp16,
        fp32

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.