zhanghai / zhanghai/MaterialFiles

FTP Client recursively only lists root directory

Open
#894 5 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
9k
Forks
736
PR merge metrics
No merged PRs in 30d

Description

version: latest
steps to reproduce:

  • add a FritzBox NAS as FTP server
  • open added storage -> works as expected
  • try to open folder

expected result:

  • contents of selected folder is shown

actual result:

  • root directory is shown again while selected folder is added to breadcrumbs

Unfortunately, I don't know what causes this to happen on the Fritzbox FTP server, but not on others.
I tested this solution posted on stackoverflow and it indeed solves the issue. (Adding changeWorkingDirectory(pathname) here)

https://user-images.githubusercontent.com/51318535/205460445-361be1c7-5b80-4c01-9475-615f1c9e8bb4.mp4

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in app/src/main/java/me/zhanghai/android/files/provider/ftp/client/FTPClientCompat.kt around the FTP directory listing path, then reproduce the behavior with a FritzBox FTP server. Verify that opening a folder displays that folder's contents rather than the root, while preserving the breadcrumb behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile, networking
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.