zhanghai / zhanghai/MaterialFiles
External subtitle support in SMB
@zhanghai is already working on this.
Since May 22, 2022.
- Dominant language
- Kotlin
- Stars
- 9k
- Forks
- 736
- PR merge metrics
- No merged PRs in 30d
Description
Locally, playing video files with external subtitles from the same directory works fine. However, when playing files from an SMB directory, external subtitles are not being picked up. The video players I'm using are mpv-android and MXPlayer.
For example, the following works:
Local Device/
├─ Some Folder/
│ ├─ Psycho-Pass 3 - First Inspector.ass
│ ├─ Psycho-Pass 3 - First Inspector.mkv
Both video players pick up the external subtitles.
However, this does not work:
SMB/
├─ Some SMB Folder/
│ ├─ Psycho-Pass 3 - First Inspector.ass
│ ├─ Psycho-Pass 3 - First Inspector.mkv
Both video players do not pick up the external subtitles.
MXPlayer's built-in implementation of an SMB browser is poor, but it does properly pick up external subs. So, I'm hoping it's possible with MaterialFiles, as well.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.