zhanghai / zhanghai/MaterialFiles
Consider showing labels for toolbar buttons on tablets
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 9k
- Forks
- 736
- PR merge metrics
- No merged PRs in 30d
Description
As mentioned in #380:
Android design guidelines said one shouldn't show toolbar icon label on phone, although they may do so on tablet.
I agree labels can be problematic on a phone due to space constraints; that said, from a usability standpoint, I think it would be nice for Material Files to display them when on a the tablet formfactor (I'm thinking in particular of my non-tech-literate family members as a usecase here; to them, icons are cryptic, in any application).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the related issue #380 and reviewing how Material Files currently handles toolbar buttons across phone and tablet form factors. Determine the expected tablet-only behavior and verify that labels appear on tablets without causing the phone layout problems described in the issue.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kotlin
- Domain
- mobile
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100