zhanghai / zhanghai/MaterialFiles

Support for ed25519 key for SFTP/SSH (`Unsupported Algorithm [1.3.101.112]`)

Open
#1,439 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Kotlin
Stars
9k
Forks
736
PR merge metrics
No merged PRs in 30d

Description

I wanted to add a SFTP server with key-based auth but it crashes with the stack trace below when pressing "Add" or "Save" on the add/edit SFTP dialog.

The cause appears to be that my key is using ed25519 algorithm which appears to be unsupported. The key was generated in ConnectBot.

I am using version 1.7.4 (39) from F-Droid on Android 13. I noticed that the last release was almost a year ago, but I haven't tested whenever it is fixed or not in the current development version.

java.lang.IllegalArgumentException: Unsupported Algorithm [1.3.101.112]
	at R6.b.l(SourceFile:71)
	at e6.d.c(SourceFile:91)
	at me.zhanghai.android.files.storage.EditSftpServerFragment.k0(SourceFile:338)
	at q5.o.onClick(SourceFile:96)
	at android.view.View.performClick(View.java:7516)
	at com.google.android.material.button.MaterialButton.performClick(SourceFile:10)
	at android.view.View.performClickInternal(View.java:7490)
	at android.view.View.-$$Nest$mperformClickInternal(Unknown Source:0)
	at android.view.View$PerformClick.run(View.java:29349)
	at android.os.Handler.handleCallback(Handler.java:942)
	at android.os.Handler.dispatchMessage(Handler.java:99)
	at android.os.Looper.loopOnce(Looper.java:346)
	at android.os.Looper.loop(Looper.java:475)
	at android.app.ActivityThread.main(ActivityThread.java:7950)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:942)

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at EditSftpServerFragment.k0 in the stack trace and compare the reported 1.7.4 behavior with the current development version. Reproduce saving an SFTP server configured with a ConnectBot-generated ed25519 key; done means the dialog no longer crashes and key-based authentication is supported.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
authentication, mobile-dev, networking
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.