zhanghai / zhanghai/MaterialFiles
Use EncryptedSharedPreferences for storing credentials
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 9k
- Forks
- 736
- PR merge metrics
- No merged PRs in 30d
Description
First of all, thank you for this great file manager.
One thing I noticed, is that the application uses SharedPreferences for storing credentials, like the SMB password. These store the values in plain text. Would it be possible to use EncryptedSharedPreferences instead, so that the settings are encrypted?
Thanks and best regards.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the SharedPreferences usage that stores credentials such as SMB passwords, then review how those settings are read and written. Compare the existing storage flow with Android's EncryptedSharedPreferences requirement. Done means credential values are no longer stored in plain text and the relevant settings continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100