zhanghai / zhanghai/MaterialFiles
[Feature Request, Security] Allow to ask for ssh key password on-demand (sftp)
Nobody has claimed this yet.
- Dominant language
- Kotlin
- Stars
- 9k
- Forks
- 736
- PR merge metrics
- No merged PRs in 30d
Description
First of all, thanks for this extraordinarily well-focussed file manager!
I'd like to suggest a feature, I believe the effort should be rather low:
Feature
When adding a new sftp connection using a password-protected ssh-key, it would be nice to have the option to leave the password blank (not store the password in the app) and be prompted whenever a connection is attempted.
Current behaviour
The current behaviour of the app is to reject saving the connecting as the ssh-key cannot be decrypted without a password.
Screenshot
Estimated effort
The highest effort in implementing this feature would probably be the additional UI of showing a password prompt upon connection. It would however be very useful security-wise. Again, thank you very much for creating this app! :)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the SFTP connection setup and the SSH-key password validation, then trace how connection attempts handle credentials. The feature is complete when a password-protected key can be saved without a stored password and the app prompts for it whenever the connection is attempted.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- android, kotlin
- Domain
- mobile, security
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100