Keyboard Shortcuts Issue?
Open
Nobody has claimed this yet.
bug
Component-UI
Usability
- Dominant language
- Java
- Stars
- 15.8k
- Forks
- 2.6k
- Avg merge
- 13h 16m
- Merged PRs (30d)
- 17
Description
Note this is not an exact transcript from IRC, but provides the parts relevant to this issue.
Steps to reproduce:
08:33 kingthorin I think i just discovered an issue with Keyboard shortcuts, can you try something for me?
08:33 kingthorin Goto Options > Keyboard
08:34 kingthorin select something like Tips and Tricks and set the combination to ctrl - F1
08:34 kingthorin hit set, and ok
08:34 kingthorin try the combo, does it just do nothing or make the tooltip for the options button come up?
08:35 kingthorin (Go back to options > keyboard and note it didn't actually set)
Follow-on discussion:
08:35 thc202 morning kingthorin
08:35 kingthorin at least that's what I'm experiencing on Win 7 (Dev and 2.6.0)
08:35 kingthorin heya thc202
08:37 thc202 does it need to be Ctrl + F1 (that switches my workspaces
08:37 kingthorin well that's the one I noticed the issue with
08:37 psiinon I think some key combinations cant be changed on some platforms
08:39 thc202 kingthorin, right, it does not seem to persist the changes on that shortcut (changing others menus work)
08:47 kingthorin @thc202 it doesn't seem to be limited to the particular item, I noticed it last night while I was working on that new menuitem
08:47 thc202 ok
08:47 kingthorin also if you're in dev mode and set ctrl+shit+f1 then it seems to do a toString on the maintoolbar and dumps the info to the eclipse console
08:48 kingthorin it's something about F1 "I think"
08:49 thc202 yeah, it might be, some shortcuts might be from Swing itself (and not reaching ZAP code)
08:50 kingthorin oh ok, never thought of swing intercepting something
08:50 kingthorin should I open an issue for that, or just keep it in the back of our heads?
08:52 thc202 yeah, worth opening an issue
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the problem through Options > Keyboard with Ctrl+F1, then trace the keyboard-shortcut handling described in the issue. Confirm whether the shortcut is intercepted before reaching ZAP and ensure the assigned shortcut persists and invokes the selected action.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- desktop
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100