Wrong order of loading operations when loading a session
Open
Nobody has claimed this yet.
Component-Logic
Maintainability
Priority-Critical
Type-Defect
- Dominant language
- Java
- Stars
- 15.8k
- Forks
- 2.6k
- Avg merge
- 13h 16m
- Merged PRs (30d)
- 17
Description
When loading an existing session, when a Context is first created/loaded, the ContextDataFactories'
loadContextData methods are called first (according to org.parosproxy.paros.model.Session.java:338),
before actually loading the Context's core properties (include/exlude regexes, name
etc.) - as per org.parosproxy.paros.model.Session.java:350.
This posses a serious issue for Extensions/ContextDataFactories that need those properties
(most notably include/exclude regexes) during their data loading. An extension that,
for example, needs to know if a node is in the Context it's trying to load will not
be able to do so as the include/exclude patterns are still empty at the moment.
Original issue reported on code.google.com by cosminstefanxp on 2014-08-18 08:43:04
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in org.parosproxy.paros.model.Session.java at the loading flow around lines 338 and 350, and inspect the ContextDataFactories loadContextData methods. Verify the order in which Context core properties and factory callbacks are processed. Done means factories can access the loaded Context properties, including include/exclude regexes, during session loading.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100