zalando / zalando/postgres-operator

[Feature Request] Addition of a postgresl resource "podLabels" similar to "podAnnotations"

Open
#2,882 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
5.2k
Forks
1.1k
Avg merge
2d 16h
Merged PRs (30d)
3

Description

Please, answer some short questions which should help us to understand your problem / question better?

Using version 1.14.0
We run on AKS
Yes! Running in production for over a year!
This is a feature request for a "podLabels" setting similar to "podAnnotations"

I am aware of the configuration level setting for "inherited_labels" and "inherited_annotations"; however this won't work for our application as we are applying an annotation to our pods for istio (preventing the sidecar from being injected). If we used this, it would apply this annotation / label to all of the resources that zalando is creating (secrets, pdb, etc...); this is reported back as a warning in istio.

The current "podAnnotations" seems to work great for us right now, it applies the annotation to both the spilo and pgbouncer pods (which is what we want). Istio, however is moving towards labels instead of annotations. I looked for an equivalent with labels but didn't find one. Is this something that could be added?

We've had good experiences with Zalando over the past year, thanks for your continued efforts!

Some general remarks when posting a bug report:

  • Please, check the operator, pod (Patroni) and postgresql logs first. When copy-pasting many log lines please do it in a separate GitHub gist together with your Postgres CRD and configuration manifest.
  • If you feel this issue might be more related to the Spilo docker image or Patroni, consider opening issues in the respective repos.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing podAnnotations handling and compare it with the inherited_labels and inherited_annotations settings. Implement the analogous podLabels behavior so labels apply to the Spilo and pgbouncer pods without propagating to other resources, then verify both pod types and the existing annotation behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes, postgresql
Domain
databases, devops, infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.