zalando / zalando/postgres-operator

regsitry/repository/tag-approach for spilo and logical-backup image

Open
#2,689 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
5.2k
Forks
1.1k
Avg merge
2d 16h
Merged PRs (30d)
3

Description

Please, answer some short questions which should help us to understand your problem / question better?

  • Which image of the operator are you using? ghcr.io/zalando/postgres-operator:v1.12.2
  • Where do you run it - cloud or metal? Kubernetes or OpenShift? AWS K8s/EKS
  • Are you running Postgres Operator in production? yes
  • Type of issue? feature request

Some general remarks when posting a bug report:

  • Please, check the operator, pod (Patroni) and postgresql logs first. When copy-pasting many log lines please do it in a separate GitHub gist together with your Postgres CRD and configuration manifest.
  • If you feel this issue might be more related to the Spilo docker image or Patroni, consider opening issues in the respective repos.

When using the helm chart, the operator allows to generate the image through

image:
  registry: ghcr.io
  repository: zalando/postgres-operator
  tag: v1.12.2

This is a good approach, as we can simply update the registry to point to our private-registry, while still rely on the Chart's default values to select the correct tag.
e.g.

image:
  registry: my-pullthrough-registry.com
  repository: zalando/postgres-operator
  tag: v1.12.2

However, the Spilo docker image configGeneral.docker_image and logicalbackup image configLogicalBackup.logical_backup_docker_image use a full image path, which means we cannot reply on the Chart's default values to update the tag when updating the chart version, as we use a custom registry.

It would be a small effort to follow the same, more dynamic regsitry/repository/tag-approach.

Let me know what you think.
Thanks!

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the Helm chart values and templates that define configGeneral.docker_image and configLogicalBackup.configLogicalBackup.logical_backup_docker_image, then compare them with the operator image's registry, repository, and tag values. Done means both images can use separate registry, repository, and tag settings so chart defaults update their tags when the chart version changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
docker, helm, kubernetes, postgresql
Domain
databases, devops, infrastructure
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.