zalando / zalando/postgres-operator
LOGICAL_BACKUP_S3_BUCKET is used in the path for Azure uploads, azure does not require the bucket name on the command line as a prefix.
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.2k
- Forks
- 1.1k
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 3
Description
Please, answer some short questions which should help us to understand your problem / question better?
- Which image of the operator are you using? registry.opensource.zalan.do/acid/logical-backup:v1.10.0
- Where do you run it - cloud or metal? Kubernetes or OpenShift? AKS
- Are you running Postgres Operator in production? yes
- Type of issue? Enhancement
It's this line: https://github.com/zalando/postgres-operator/blob/master/docker/logical-backup/dump.sh#L48
I wonder why that variable is there. It results in "my-bucket-url" if it's not set, which seems undesirable.
EDIT seems like setting it to "" will result in a no name folder, also not great.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at docker/logical-backup/dump.sh line 48 and inspect how LOGICAL_BACKUP_S3_BUCKET is used for Azure uploads. Verify the Azure path does not receive an unnecessary bucket-name prefix while preserving the expected S3 behavior; the issue does not mention a test file to run.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, postgresql, shell
- Domain
- cloud, databases
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100