zalando / zalando/postgres-operator
Dump size coef=5 is won't always work.
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.2k
- Forks
- 1.1k
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 3
Description
Logical backup script assumes that the compressed stream of the backup is 1/5 the size of the raw dump. This is not always true, and I was having an issue with a >400Gb backup. I've tested setting it to 3 for this exact job, which works. Will come a PR for this soon.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with docker/logical-backup/dump.sh at line 11 and inspect how the backup size is estimated from the raw dump. Compare the reported coefficient-3 result with the current coefficient-5 assumption; done means large logical backups are sized reliably rather than failing because the fixed compression ratio is inaccurate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- postgresql, shell
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100