zalando / zalando/postgres-operator
/run/etc/wal-e.d/env-clone-* uses Instance Profile, regardless if Access Key is configured.
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 5.2k
- Forks
- 1.1k
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 3
Description
Please, answer some short questions which should help us to understand your problem / question better?
- Which image of the operator are you using? e.g. registry.opensource.zalan.do/acid/postgres-operator:v1.6.3
- Where do you run it - cloud or metal? Kubernetes or OpenShift? AWS K8s | Azure
- Are you running Postgres Operator in production? yes
- Type of issue? Bug report
When generating /run/etc/wal-e.d/env-clone-*, AWS_INSTANCE_PROFILE will always be set to true, and the Access Key will never be included, regardless of what the user has actually configured.
This causes the restore process to break if the instance profile is not used, and an access key is used instead.
I manually updated the env-clone-* directory to remove AWS_INSTANCE_PROFILE and add the AWS access key environment variables, and this resolves this specific issue.
Unfortunately there does not appear to be any way to do this via a pod-env-override.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how /run/etc/wal-e.d/env-clone-* is generated and how the pod-env-override is handled. Compare the generated environment for AWS instance-profile and access-key configurations; done means restore works with configured access keys without forcing AWS_INSTANCE_PROFILE.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- aws, go, kubernetes, postgresql
- Domain
- cloud, databases, infrastructure
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100