yysskk / yysskk/SwipeMenuViewController

maintain state on navigation pop

Open
#92 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
1.3k
Forks
128
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
Hi,
I'm using this module as SwipeMenuView, because my controller already extends a my base controller.
For each tab I'm using another my controller that extends UITableViewController; each cells of these tables push to another controller programmatically.

I noticed this issue:

  1. Go to controller with SwipeMenuView
  2. Swipe to third tab
  3. Click on a 30th cell and go to another controller
  4. Click on back button in navigation bar
  5. I return in controller with SwipeMenuView with first tab selected [BUG]

Expected result: return in controller with SwipeMenuView with third tab selected and table view scrolled to previous position

consider that:

  1. swipeMenuView.reloadData is not called on pop because I implemented a mecanism for avoid some action on back
  2. I noticed that when I left (on push) my swipe menu controller SwipeMenuView willsetup and SwipeMenuView didsetup are called. When I return (on pop) in my swipe menu controller SwipeMenuView willsetup and SwipeMenuView didsetup are called two time for each. Why?

thanks

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the tab-selection and navigation-pop sequence in SwipeMenuViewController using the UIKit navigation flow described in the issue. Inspect how the selected tab, table scroll position, and setup callbacks behave when returning from a pushed controller. Done means the third tab and its previous scroll position are preserved after pop, without duplicate setup callbacks.

Written by the indexing model from the issue text.

Assessment

Tech stack
ios, swift
Domain
mobile-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.